v5 chore: fully remove deprecated function call types from the tool runner #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,7 +134,7 @@ describe('instantiate azure client', () => { | |||
|
|
|||
| const spy = jest.spyOn(client, 'request'); | |||
|
|
|||
| await expect(client.get('/foo', { signal: controller.signal })).rejects.toThrowError(APIUserAbortError); | |||
| await expect(client.get('/foo', { signal: controller.signal })).rejects.toThrow(APIUserAbortError); | |||
There was a problem hiding this comment.
question: why change this?
There was a problem hiding this comment.
Was also flagged as deprecated and azure is custom code. We should update codegen with this change too.
| import OpenAI from '../index'; | ||
| import { isAutoParsableTool, parseChatCompletion } from '../lib/parser'; | ||
| import { RequestOptions } from '../internal/request-options'; | ||
| import type { RequestOptions } from '../internal/request-options'; |
There was a problem hiding this comment.
aside: can / should we update eslint to automatically add these type annotations?
| readonly eventFunctionCallResults: string[] = []; | ||
|
|
||
| finalContent: string | null = null; | ||
| finalMessage: ChatCompletionMessageParam | undefined; | ||
| finalChatCompletion: OpenAI.Chat.ChatCompletion | undefined; | ||
| finalFunctionCall: OpenAI.Chat.ChatCompletionMessage.FunctionCall | undefined; | ||
| finalFunctionCall: OpenAI.Chat.ChatCompletionMessageToolCall.Function | undefined; |
There was a problem hiding this comment.
hmm maybe we should also rename these to tool calls?
cc @kwhinnery-openai do you have any thoughts here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runFunctions was already removed, this cleans up the last usage of the deprecated function calling types in the tool runner